[vlc-devel] [PATCH] qt: playlist: use item title if available

[Jean-Baptiste Kempf]

LGTM

On Tue, 20 Apr 2021, at 17:26, Romain Vimont wrote:
> Use the meta title if it is available, use the item name otherwise.
> 
> Fixes #25648
> ---
>  modules/gui/qt/playlist/playlist_item.cpp | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/modules/gui/qt/playlist/playlist_item.cpp 
> b/modules/gui/qt/playlist/playlist_item.cpp
> index 0d7d460abe..18ba080d3c 100644
> --- a/modules/gui/qt/playlist/playlist_item.cpp
> +++ b/modules/gui/qt/playlist/playlist_item.cpp
> @@ -73,15 +73,20 @@ QUrl PlaylistItem::getUrl() const
>  void PlaylistItem::sync() {
>      input_item_t *media = vlc_playlist_item_GetMedia(d->item.get());
>      vlc_mutex_lock(&media->lock);
> -    d->title    = media->psz_name;
>      d->duration = media->i_duration;
>      d->url      = media->psz_uri;
>  
>      if (media->p_meta) {
> +        d->title   = vlc_meta_Get(media->p_meta, vlc_meta_Title);
>          d->artist  = vlc_meta_Get(media->p_meta, vlc_meta_Artist);
>          d->album   = vlc_meta_Get(media->p_meta, vlc_meta_Album);
>          d->artwork = vlc_meta_Get(media->p_meta, vlc_meta_ArtworkURL);
>      }
> +
> +    if (d->title.isNull())
> +        /* If there is no title, use the item name */
> +        d->title = media->psz_name;
> +
>      vlc_mutex_unlock(&media->lock);
>  }
>  
> -- 
> 2.31.0
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


-- 
Jean-Baptiste Kempf -  President
+33 672 704 734