[vlc-devel] [PATCH 2/5] es_out: save user group_id

[Thomas Guillem]

On Mon, Feb 1, 2021, at 16:59, Rémi Denis-Courmont wrote:
> Le maanantaina 1. helmikuuta 2021, 17.52.22 EET Thomas Guillem a écrit :
> > This will allow to select a program before it is created.
> > ---
> >  src/input/es_out.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/src/input/es_out.c b/src/input/es_out.c
> > index d9fc1ee495..b3b3562105 100644
> > --- a/src/input/es_out.c
> > +++ b/src/input/es_out.c
> > @@ -3285,6 +3285,8 @@ static int EsOutVaControlLocked( es_out_t *out,
> > input_source_t *source, int i = va_arg( args, int );
> >          es_out_pgrm_t *p_pgrm;
> > 
> > +        p_sys->i_group_id = i;
> > +
> >          vlc_list_foreach(p_pgrm, &p_sys->programs, node)
> >              if( p_pgrm->i_id == i )
> >              {
> 
> It's a little strange that the property is only set. Presumably, this would 
> render an existing initialisation redundant?
> 

This property is initialized with the "program" option:

p_sys->i_group_id = var_GetInteger( p_input, "program" );

and then never set again.

It is read when a new program is added, to trigger program selection or not. The simple rule is
 - group_id = 0, default, select the first program
 - group_id != 0, select only the corresponding program.

When programs were selected on live, this property was not used since it only compared the id with existing programs.

> -- 
> Реми Дёни-Курмон
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel