[vlc-devel] [PATCH] gl_common: disable GL_ASSERT_NOERROR in release

[Thomas Guillem]

LGTM

On Fri, Feb 5, 2021, at 10:36, Alexandre Janniaux wrote:
> ...and remove the obsolete comment, the cases have been fixed and should
> be fixed if it happens again.
> 
> We don't need "proper event handling" as most errors are coming from
> programmation errors, except in a few tests (like 16bit texture test)
> which have been fixed already.
> ---
>  modules/video_output/opengl/gl_common.h | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/modules/video_output/opengl/gl_common.h 
> b/modules/video_output/opengl/gl_common.h
> index 45700e4cb7..d8c9e43842 100644
> --- a/modules/video_output/opengl/gl_common.h
> +++ b/modules/video_output/opengl/gl_common.h
> @@ -172,12 +172,7 @@
>  # define APIENTRY
>  #endif
>  
> -/* FIXME: GL_ASSERT_NOERROR disabled for now because:
> - * Proper GL error handling need to be implemented
> - * glClear(GL_COLOR_BUFFER_BIT) throws a 
> GL_INVALID_FRAMEBUFFER_OPERATION on macOS
> - * assert fails on vout_display_opengl_Delete on iOS
> - */
> -#if 1
> +#ifndef NDEBUG
>  # define HAVE_GL_ASSERT_NOERROR
>  #endif
>  
> -- 
> 2.28.0
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel