[vlc-devel] [PATCH] Revert "pulse: use pa_stream_begin_write()" (fixes #25187)

Rémi Denis-Courmont remi at remlab.net
Sat Feb 6 16:57:34 UTC 2021


Le lauantaina 6. helmikuuta 2021, 18.40.18 EET Thomas Guillem a écrit :
> Hello,
> 
> My comment in the trac issue is still now answered.

???

> Pulseaudio is the only aout module that flush in case of overflow.

Originally, the PulseAudio parameters were picked such that overflow would not 
normally occur, and so it could be treated as a major failure to recover from. 
There's no big secret there.

> I really think it's should be fixed (by waiting from Play()).

Waiting in Play() will make volume, mute and migration unresponsive, so it is 
undesirable.

I don't see what this had to do with this patch either way.

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/





More information about the vlc-devel mailing list