[vlc-devel] [PATCH 08/10] vout: don't clobber crop borders when updating

[Rémi Denis-Courmont]

Le maanantaina 8. helmikuuta 2021, 9.58.58 EET Steve Lhomme a écrit :
> If the code is next called with vout_UpdateDisplaySourceProperties()
> osys->crop.left (and the others) will be 0. This effectively resets a
> previous call to vout_SetDisplayCrop(). I don't know if it's intentional
> or not.

I tihnk it's left-over from the old vout display management loop and its error 
handling.

> I don't think there's a good way to handle this case: the user
> set a manual crop on certain video dimension and then the video
> dimension changes.

That's the FIXME that this patch fixes and removes: We need to keep track of 
the _crop mode_, so that the effective crop window can be recomputed in 
accordance with user settings even if the source format changes.

-- 
Rémi Denis-Courmont
http://www.remlab.net/