[vlc-devel] [PATCH 1/2] vout: add a resize acknowledgement callback

Rémi Denis-Courmont remi at remlab.net
Tue Feb 9 19:39:57 UTC 2021


Le tiistaina 9. helmikuuta 2021, 21.29.23 EET Thomas Guillem a écrit :
> > @@ -214,13 +228,16 @@ typedef struct vout_display_window
> > 
> >  } vout_display_window_t;
> >  
> >  static void vout_display_window_ResizeNotify(vout_window_t *window,
> > 
> > -                                             unsigned width, unsigned
> > height) +                                             unsigned width,
> > unsigned height, +                                            
> > vout_window_ack_cb cb, +                                             void
> > *opaque)
> > 
> >  {
> >  
> >      vout_display_window_t *state = window->owner.sys;
> >      vout_thread_t *vout = state->vout;
> > 
> > +    struct vout_window_ack_data data = { window, cb, opaque };
> 
> Nit: add  const

That does not seem correct here. The callback('s callback) needs non-const 
data.

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/





More information about the vlc-devel mailing list