[vlc-devel] [PATCH 2/2] xdg-shell: acknowledge size change timely (fixes #25112)

Alexandre Janniaux ajanni at videolabs.io
Tue Feb 9 20:00:36 UTC 2021


Hi,

I have to disagree:

>  If it works and you get black bars, good. If the window insists on retaining the video aspect, then bad.

I get correct frame perfect black bar when forcing the (tiling) resize in sway, though
I cannot resize with the window grips. Without your patch, the black bars undeterministically
have transparent or opaque grey parts in the location it was resized.

So it seems there is stil an issue with the actual resizing capabilities, but definitively
not with the OpenGL vout, at least on sway.

Regards,
--
Alexandre Janniaux
Videolabs



On Tue, Feb 09, 2021 at 08:57:34PM +0200, Rémi Denis-Courmont wrote:
> Le tiistaina 9. helmikuuta 2021, 20.11.50 EET Alexandre Janniaux a écrit :
> > Hi,
> >
> > LGTM,
> >
> > It also fixes https://trac.videolan.org/vlc/ticket/18434 on wayland
> > sway with the OpenGL output,
>
> Uh, I can't imagine how that would be. #18434 is a (or, at least, was) bug in
> the OpenGL output, not any specific window provider. And it is not even really
> related to timing.
>
> > which might also be the same ticket as
> > https://trac.videolan.org/vlc/ticket/25109.
>
> --
> Реми Дёни-Курмон
> http://www.remlab.net/
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list