[vlc-devel] [PATCH] video_filter: Makefile: always define ci_filters's LDFLAGS

Alexandre Janniaux ajanni at videolabs.io
Wed Feb 10 10:41:20 UTC 2021


Otherwise, AM_LDFLAGS won't get added to the target on iOS since there
is a target (though unused) defining LDFLAGS for MacOSX, leading to
incorrect build of the plugin.
---
 modules/video_filter/Makefile.am | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/modules/video_filter/Makefile.am b/modules/video_filter/Makefile.am
index d265d44f2f..be70b6b90d 100644
--- a/modules/video_filter/Makefile.am
+++ b/modules/video_filter/Makefile.am
@@ -111,8 +111,9 @@ video_filter_LTLIBRARIES = \
 
 # macOS / iOS hardware video filters
 libci_filters_plugin_la_SOURCES = video_filter/ci_filters.m codec/vt_utils.c codec/vt_utils.h
+libci_filters_plugin_la_LDFLAGS = $(AM_LDFLAGS) -rpath '$(video_filterdir)'
 if HAVE_OSX
-libci_filters_plugin_la_LDFLAGS = $(AM_LDFLAGS) -rpath '$(video_filterdir)' \
+libci_filters_plugin_la_LDFLAGS += \
 	-Wl,-framework,Foundation -Wl,-framework,CoreGraphics -Wl,-framework,CoreImage \
 	-Wl,-framework,CoreVideo -Wl,-framework,OpenGL
 video_filter_LTLIBRARIES += libci_filters_plugin.la
-- 
2.30.1



More information about the vlc-devel mailing list