[vlc-devel] [PATCH] demux: always install the mock module

[Thomas Guillem]

On Wed, Feb 10, 2021, at 10:42, Steve Lhomme wrote:
> It should only be on debug builds. We don't want to install it on 
> millions of regular users.

AC_ARG_ENABLE([debug],
  AS_HELP_STRING([--disable-debug],
    [disable run-time assertions (default enabled)]),,
...

This should not have anything to do with what module is shipped.

Besides, some external libVLC apps may want to do their testsuite on a libVLC release build.

The plugin size is 97 KB on Windows. Quite heavy for a "debug" plugin.


> 
> On 2021-02-10 10:05, Thomas Guillem wrote:
> > It will still disabled by default because of the 0 priority.
> > 
> > It can be used by external libVLC apps for their test suite.
> > ---
> >   modules/demux/Makefile.am | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/modules/demux/Makefile.am b/modules/demux/Makefile.am
> > index 6e2b5bfa006..8e52fa5de50 100644
> > --- a/modules/demux/Makefile.am
> > +++ b/modules/demux/Makefile.am
> > @@ -535,7 +535,7 @@ demux_LTLIBRARIES += libnoseek_plugin.la
> >   libdemux_mock_plugin_la_SOURCES = demux/mock.c
> >   libdemux_mock_plugin_la_LDFLAGS = $(AM_LDFLAGS) -rpath '$(demuxdir)'
> >   libdemux_mock_plugin_la_LIBADD = $(LIBM)
> > -noinst_LTLIBRARIES += libdemux_mock_plugin.la
> > +demux_LTLIBRARIES += libdemux_mock_plugin.la
> >   
> >   BUILT_SOURCES += demux/json/grammar.h
> >   libvlc_json_la_SOURCES = \
> > -- 
> > 2.30.0
> > 
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> > 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel