[vlc-devel] [PATCH 09/17] clock: remove monotonic fallback

[Thomas Guillem]

It's handled by the input clock and will behave like VLC 3.0 now.

Is there a problem with that ?

On Tue, Feb 16, 2021, at 17:17, Francois Cartegnie wrote:
> Le 15/02/2021 à 11:15, Thomas Guillem a écrit :
> 
> > -static vlc_tick_t
> > -vlc_clock_monotonic_to_system_locked(vlc_clock_t *clock, vlc_tick_t now,
> > -                                     vlc_tick_t ts, double rate)
> > -{
> > -    vlc_clock_main_t *main_clock = clock->owner;
> > -
> > -    if (clock->priority < main_clock->wait_sync_ref_priority)
> > -    {
> > -        /* XXX: This input_delay calculation is needed until we (finally) get
> > -         * ride of the input clock. This code is adapted from input_clock.c and
> > -         * is used to introduce the same delay than the input clock (first PTS
> > -         * - first PCR). */
> > -        const vlc_tick_t pcr_delay =
> > -            main_clock->first_pcr.system == VLC_TICK_INVALID ? 0 :
> > -            (ts - main_clock->first_pcr.stream) / rate +
> > -            main_clock->first_pcr.system - now;
> > -
> > -        const vlc_tick_t input_delay = main_clock->input_dejitter + pcr_delay;
> > -
> > -        const vlc_tick_t delay =
> > -            __MAX(input_delay, main_clock->output_dejitter);
> > -
> > -        main_clock->wait_sync_ref_priority = clock->priority;
> > -        main_clock->wait_sync_ref = clock_point_Create(now + delay, ts);
> > -    }
> > -    return (ts - main_clock->wait_sync_ref.stream) / rate
> > -        + main_clock->wait_sync_ref.system;
> > -}
> 
> Since decoder implicit delay/dejitter handling is gone, that can no 
> longer works as before
> 
> 
> -- 
> Francois Cartegnie
> VideoLAN - VLC Developer
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel