[vlc-devel] [PATCH v3 06/10] video_output: conditionnally render on display

Alexandre Janniaux ajanni at videolabs.io
Tue Feb 16 17:01:47 UTC 2021


Hi,

Yes, it's supposed to at least be a subset of what is locked
by the display_lock, since there are still issues to solve on
iOS to be able to report events taking the display_lock while
having the display/opengl module being opened. I have a long
term plan to fix this, but I'm not sure how much work it
would take right now.

It's also wrapping filter because of the last discussion, but
this part can be removed.

Regards,
--
Alexandre Janniaux
Videolabs

On Tue, Feb 16, 2021 at 06:50:53PM +0200, Rémi Denis-Courmont wrote:
> Le tiistaina 16. helmikuuta 2021, 17.25.46 EET Alexandre Janniaux a écrit :
> > Don't prepare/display if rendering is disabled. Rendering can only be
> > disabled when taking the display_lock so the prepare/display cannot be
> > done partially because of this patch.
>
> This new lock does not seem to have any purpose, since basically nothing is
> not already locked by some other lock, namely display's or filter's. And it
> causes the window and filters to interlock, which seems at best undesirable.
>
> -1
>
> --
> Реми Дёни-Курмон
> http://www.remlab.net/
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list