[vlc-devel] [PATCH v2] video_output: wait half the extra time we have without getting the display_lock

[Rémi Denis-Courmont]

Le maanantaina 22. helmikuuta 2021, 9.47.25 EET Steve Lhomme a écrit :
> Since f1bf7ce5b4480a3d38d54c7ae1d1564f0670d83f we start the rendering much
> earlier than before, so we have more time to do things if necessary.
> 
> The problem is that for almost all the duration of the call display_lock is
> held. So it's blocking all other UI related events from being handled. Even
> if we are going to spend most of the time waiting until we can do the
> display.
> 
> This patch waits a bit before locking the display_lock when we estimate we
> will have so extra time before doing the display/swap.

We can't block the UI for that long. If you hold the lock for two long, you 
will first make the UI unresponsive, and then eventually kill the connection to 
the display server and end the whole process.

So eventually, we have to release the lock between prepare and display. Which 
means we have to change the interface whether you like it or not.

Halving the wait time is not proper even as a work-around. We should not wait 
longer than we used to (which was arguably too long but grand father clause 
apply).

-- 
レミ・デニ-クールモン
http://www.remlab.net/