[vlc-devel] [PATCH v2 0/6] OpenGL video filters

Alexandre Janniaux ajanni at videolabs.io
Fri Feb 26 17:30:53 UTC 2021


Hi,

LGTM, though the renaming is a bit heavy. We can iterate
later on that.

Regards,
--
Alexandre Janniaux
Videolabs
On Fri, Feb 26, 2021 at 06:10:30PM +0100, Romain Vimont wrote:
> v1: https://mailman.videolan.org/pipermail/vlc-devel/2021-February/142295.html
>
> Changes:
>  - only enable egl_pbuffer on Android (further GBM platform support patch
>    incoming)
>  - minor codestyle fixes
>
> Regards
>
> Branch: https://code.videolan.org/rom1v/vlc/-/commits/video_filter_opengl.2
>
> Alexandre Janniaux (3):
>   opengl: add CreateOffscreen API
>   video_filter: add egl_pbuffer filter plugin
>   video_filter: add opengl filter executor
>
> Romain Vimont (3):
>   opengl: replace runtime check by assertion
>   opengl: add vflip option to "draw" filter
>   opengl: add mock filter
>
>  include/vlc_opengl.h                      |  26 +-
>  modules/video_filter/Makefile.am          |  29 ++
>  modules/video_filter/egl_pbuffer.c        | 467 ++++++++++++++++++++++
>  modules/video_filter/opengl.c             | 327 +++++++++++++++
>  modules/video_output/opengl/Makefile.am   |  30 ++
>  modules/video_output/opengl/filter_draw.c |  22 +-
>  modules/video_output/opengl/filter_draw.h |  10 +-
>  modules/video_output/opengl/filter_mock.c | 411 +++++++++++++++++++
>  modules/video_output/opengl/gl_api.c      |   3 +
>  modules/video_output/opengl/gl_common.h   |  17 +
>  src/libvlccore.sym                        |   1 +
>  src/video_output/opengl.c                 |  54 +++
>  12 files changed, 1391 insertions(+), 6 deletions(-)
>  create mode 100644 modules/video_filter/egl_pbuffer.c
>  create mode 100644 modules/video_filter/opengl.c
>  create mode 100644 modules/video_output/opengl/filter_mock.c
>
> --
> 2.30.1
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list