[vlc-devel] [PATCH 2/2] cli: fix SIGSEGV when command has an argument

["zhilizhao(赵志立)"]

Hi,
I have sent a same patch for it
https://mailman.videolan.org/pipermail/vlc-devel/2021-February/141881.html

I found another issue, the function argument "const char *line” is modified by
        *(arg++) = '\0’;
I’m not sure whether the ‘const’ modifier should be removed or not.


> On Feb 28, 2021, at 11:12 PM, KO Myung-Hun <komh78 at gmail.com> wrote:
> 
> ---
> modules/control/cli/cli.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/modules/control/cli/cli.c b/modules/control/cli/cli.c
> index b134e471bf..d24d7f7e4c 100644
> --- a/modules/control/cli/cli.c
> +++ b/modules/control/cli/cli.c
> @@ -325,7 +325,7 @@ error:      wordfree(&we);
>         arg += strspn(arg, " ");
> 
>         if (*arg)
> -            count++;
> +            args[count++] = arg;
>     }
> #endif
> 
> -- 
> 2.30.0
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel