[vlc-devel] [PATCH] transform: inline error handling

[Alexandre Janniaux]

On Fri, Jan 08, 2021 at 01:13:55PM +0100, Steve Lhomme wrote:
> I don't find it easy. Modules, let's say just video filters in this case,
> can be loaded in various ways. For video filters it seems to always via
> filter chains (core, mosaic bridge, transcode). Just for that in transcode
> you need to follow vfilters_cfg which seems to be only used in p_filterscfg
> and then in transcode_video_filters_init(), which for a "video filter" ends
> up in psz_filters and is used with filter_chain_AppendFromString().

We can debate endlessly whether it's easy or not. However from
habits, it's pretty obvious that it's using module_need because
of the module activate function signature.

> Maybe all we need is to do this vlc_objres_clear() call in vlc_module_load()
> as all module loading ends up going through. Then we wouldn't have to worry
> anymore.

We cannot do that, there's no object to clean when you call
vlc_module_load. Using vlc_objres_clear() when we can like
Thomas suggested is imho a good approach but we need to
expose vlc_objres_clear() then.

Regards,
--
Alexandre Janniaux
Videolabs