[vlc-devel] [PATCH 1/3] threads: use common vlc_rwlock_t on all platforms

[Steve Lhomme]

On 2021-01-12 18:30, remi at remlab.net wrote:
> From: Rémi Denis-Courmont <remi at remlab.net>
> 
> ---
>   include/vlc_threads.h | 32 ++++++++++----------------------
>   src/misc/threads.c    |  4 ----
>   src/posix/thread.c    | 30 ------------------------------
>   3 files changed, 10 insertions(+), 56 deletions(-)
> 
> diff --git a/src/misc/threads.c b/src/misc/threads.c
> index 39705b008a..76c7049f00 100644
> --- a/src/misc/threads.c
> +++ b/src/misc/threads.c
> @@ -372,10 +372,7 @@ int vlc_cond_timedwait_daytime(vlc_cond_t *cond, vlc_mutex_t *mutex,
>       return ret;
>   }
>   
> -#ifdef LIBVLC_NEED_RWLOCK
>   /*** Generic read/write locks ***/
> -#include <stdlib.h>
> -#include <limits.h>

This seems to compile correctly on Windows without this. But given it's 
not included before, is it compiling on all platforms ?

Other than that this patch LGTM.