[vlc-devel] [PATCH 2/2] vlc_media_library: remove unused C variant of vlc_ml_release()

[Hugo Beauzée-Luyssen]

On Wed, Jan 20, 2021, at 2:36 PM, Hugo Beauzée-Luyssen wrote:
> On Tue, Jan 19, 2021, at 10:05 AM, Steve Lhomme wrote:
> > ---
> >  include/vlc_media_library.h | 23 +----------------------
> >  1 file changed, 1 insertion(+), 22 deletions(-)
> > 
> > diff --git a/include/vlc_media_library.h b/include/vlc_media_library.h
> > index fde638692d7..23fe300928d 100644
> > --- a/include/vlc_media_library.h
> > +++ b/include/vlc_media_library.h
> > @@ -1519,28 +1519,7 @@ static inline size_t 
> > vlc_ml_count_playlist_media( vlc_medialibrary_t* p_ml, cons
> >  }
> >  #endif /* C++ */
> >  
> > -#ifndef __cplusplus
> > -# define vlc_ml_release( OBJ ) _Generic( ( OBJ ), \
> > -    vlc_ml_show_t*: vlc_ml_show_release, \
> > -    vlc_ml_artist_t*: vlc_ml_artist_release, \
> > -    vlc_ml_album_t*: vlc_ml_album_release, \
> > -    vlc_ml_genre_t*: vlc_ml_genre_release, \
> > -    vlc_ml_media_t*: vlc_ml_media_release, \
> > -    vlc_ml_playlist_t*: vlc_ml_playlist_release, \
> > -    vlc_ml_label_list_t*: vlc_ml_label_list_release, \
> > -    vlc_ml_file_list_t*: vlc_ml_file_list_release, \
> > -    vlc_ml_artist_list_t*: vlc_ml_artist_list_release, \
> > -    vlc_ml_media_list_t*: vlc_ml_media_list_release, \
> > -    vlc_ml_album_list_t*: vlc_ml_album_list_release, \
> > -    vlc_ml_show_list_t*: vlc_ml_show_list_release, \
> > -    vlc_ml_genre_list_t*: vlc_ml_genre_list_release, \
> > -    vlc_ml_playlist_list_t*: vlc_ml_playlist_list_release, \
> > -    vlc_ml_entry_point_list_t*: vlc_ml_entry_point_list_release, \
> > -    vlc_ml_playback_states_all*: vlc_ml_playback_states_all_release, \
> > -    vlc_ml_bookmark_t*: vlc_ml_bookmark_release, \
> > -    vlc_ml_bookmark_list_t*: vlc_ml_bookmark_list_release \
> > -    )( OBJ )
> > -#else
> > +#ifdef __cplusplus
> >  static inline void vlc_ml_release( vlc_ml_show_t* show ) { 
> > vlc_ml_show_release( show ); }
> >  static inline void vlc_ml_release( vlc_ml_artist_t* artist ) { 
> > vlc_ml_artist_release( artist ); }
> >  static inline void vlc_ml_release( vlc_ml_album_t* album ) { 
> > vlc_ml_album_release( album ); }
> > -- 
> > 2.29.2
> > 
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> 
> Hi,
> 
> It's likely that the medialibrary will end up exposed in lua at some 
> point, which will need the C variants. Although I'm fine with pushing 
> this for now and reverting later on when the need actually exists.
> 

Nevermind, I missed the other patch. I'm fine calling the appropriate function directly in C, so set LGTM

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr