[vlc-devel] [PATCH 1/2] lib: media_player: remove special android case

Thomas Guillem thomas at gllm.fr
Fri Jan 22 14:32:05 UTC 2021


LGTM

On Fri, Jan 22, 2021, at 15:02, Alexandre Janniaux wrote:
> OpenGL callbacks can now work with mediacodec hardware acceleration
> without the need for Android window.
> ---
>  lib/media_player.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/lib/media_player.c b/lib/media_player.c
> index 58dfbc39fb..9341c49a68 100644
> --- a/lib/media_player.c
> +++ b/lib/media_player.c
> @@ -1036,12 +1036,7 @@ bool 
> libvlc_video_set_output_callbacks(libvlc_media_player_t *mp,
>                                         void *opaque)
>  {
>      static_assert(libvlc_video_engine_disable == 0, "No engine set 
> must default to 0");
> -#ifdef __ANDROID__
> -    //use the default android window
> -    var_SetString( mp, "window", "");
> -#else
>      var_SetString( mp, "window", "wextern");
> -#endif
>  
>      if( engine == libvlc_video_engine_gles2 )
>      {
> -- 
> 2.30.0
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list