[vlc-devel] [PATCH] mediacodec: fix orientation in --no-mediacodec-dr

Thomas Guillem thomas at gllm.fr
Mon Jan 25 08:41:46 UTC 2021


LGTM for 3.0 and 4.0

On Sat, Jan 23, 2021, at 21:31, Alexandre Janniaux wrote:
> Hi,
> 
> By the way, the issue seems to happen on 3.0 too so it'll
> proably need a backport.
> 
> Regards.
> --
> Alexandre Janniaux
> Videolabs
> 
> On Fri, Jan 22, 2021 at 04:38:02PM +0100, Alexandre Janniaux wrote:
> > Fix #25210
> > ---
> >  modules/codec/omxil/mediacodec.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/modules/codec/omxil/mediacodec.c b/modules/codec/omxil/mediacodec.c
> > index 85a7fcf03d..2788b049d0 100644
> > --- a/modules/codec/omxil/mediacodec.c
> > +++ b/modules/codec/omxil/mediacodec.c
> > @@ -1216,10 +1216,10 @@ static int Video_ProcessOutput(decoder_t *p_dec, mc_api_out *p_out,
> >
> >          /* If MediaCodec can handle the rotation, reset the orientation to
> >           * Normal in order to ask the vout not to rotate. */
> > +        p_dec->fmt_out.video.orientation = p_dec->fmt_in.video.orientation;
> >          if (p_sys->video.i_angle != 0)
> >          {
> >              assert(p_dec->fmt_out.i_codec == VLC_CODEC_ANDROID_OPAQUE);
> > -            p_dec->fmt_out.video.orientation = p_dec->fmt_in.video.orientation;
> >              video_format_TransformTo(&p_dec->fmt_out.video, ORIENT_NORMAL);
> >          }
> >
> > --
> > 2.30.0
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list