[vlc-devel] [PATCH 2/2] macosx: remove variable macosx-glcontext

Thomas Guillem thomas at gllm.fr
Tue Jan 26 14:05:50 UTC 2021


Set LGTM

On Tue, Jan 26, 2021, at 15:04, Alexandre Janniaux wrote:
> Unused since cb6b1d5fb6c28893479f737a94da2bc753cbe8b9.
> ---
>  modules/video_output/macosx.m | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/modules/video_output/macosx.m 
> b/modules/video_output/macosx.m
> index 9ce48deaaf..ee1feaad09 100644
> --- a/modules/video_output/macosx.m
> +++ b/modules/video_output/macosx.m
> @@ -162,8 +162,6 @@ static int Open (vout_display_t *vd, const 
> vout_display_cfg_t *cfg,
>          sys->vgl = NULL;
>          sys->gl = NULL;
>  
> -        var_Create(vlc_object_parent(vd), "macosx-glcontext", 
> VLC_VAR_ADDRESS);
> -
>          /* Get the drawable object */
>          id container = var_CreateGetAddress (vd, "drawable-nsobject");
>          if (!container) {
> @@ -230,9 +228,6 @@ static int Open (vout_display_t *vd, const 
> vout_display_cfg_t *cfg,
>          sys->gl->swap = OpenglSwap;
>          sys->gl->get_proc_address = OurGetProcAddress;
>  
> -        var_SetAddress(vlc_object_parent(vd), "macosx-glcontext",
> -                       [[sys->glView openGLContext] CGLContextObj]);
> -
>          const vlc_fourcc_t *subpicture_chromas;
>  
>          if (vlc_gl_MakeCurrent(sys->gl) != VLC_SUCCESS)
> @@ -273,7 +268,6 @@ static void Close(vout_display_t *vd)
>          [sys->glView setVoutDisplay:nil];
>  
>          var_Destroy (vd, "drawable-nsobject");
> -        var_Destroy(vlc_object_parent(vd), "macosx-glcontext");
>  
>          if (sys->vgl != NULL)
>          {
> -- 
> 2.30.0
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list