[vlc-devel] [PATCH] lib: add libvlc_video_get_spu_text_scale API

Thomas Guillem thomas at gllm.fr
Tue Jan 26 20:04:42 UTC 2021


Patch LGTM.


Alexandre, I think we should do a pass on all new 4.0 functions anyway to improve/fix the documentation.

On Tue, Jan 26, 2021, at 18:55, Alexandre Janniaux wrote:
> Hi,
> 
> On Mon, Jan 25, 2021 at 07:05:13PM +0100, Felix Paul Kühne wrote:
> > Hello Alexandre,
> >
> > > Am 25.01.2021 um 09:53 schrieb Alexandre Janniaux <ajanni at videolabs.io>:
> > >
> > > Hi,
> > >
> > > I have a few question relative to how the scaling value will
> > > change the behaviour:
> > >
> > > - Is the scaling continue or should it cap the scaling to
> > >   avoid aliasing of the text on multiple pixels?
> > >
> > > - Would the scaling work on text rendered with a column/row
> > >   settings, like CEA-6/708 captions iirc?
> > >
> > > - Should the scaling work on some bitmaps format too?
> >
> > Those are good questions that I cannot answer because I all checked were the libvlc bindings. Probably François can answer :)
> 
> Sure. :)
> 
> If those questions make sense, maybe we should document the
> API then, since 4.0 is not released yet anyway.
> 
> Ok for your patch anyway, but it would have been great to use
> this other modification to fill the gap in the documentation.
> 
> Regards,
> --
> Alexandre Janniaux
> Videolabs
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list