[vlc-devel] [PATCH 3/3] transcode: video: fix insertion of fps filter

[Alexandre Janniaux]

Hi,

On Tue, Jan 26, 2021 at 08:16:39PM +0100, Francois Cartegnie wrote:
> Le 26/01/2021 à 20:07, Alexandre Janniaux a écrit :
> > The dst es_format_t seems to be overriden no matter what,
> > before anything even happens, and the documentation doesn't
> > seem to require it either.
> >
> > The init() copy() clean() cycle seems to only exist in bluray,
> > mp4, adaptive and a bit of transcode.
> >
> > What would seem harmful to me is calling es_format_Clean() on
> > a non-initialized es_format but it's clearly initialized right
> > after it's declaration by es_format_Copy, or maybe I miss
> > something there.
>
> If copy does init, then what copy after copy does ?
> It leaks or... it needs to clean which makes earlier init mandatory.
>
> That's one example why we should have kept full init() clean() cycles
> everywhere, and even if the init is zero op.

Ah ok I see. I visualize es_format_Copy more like a strdup
equivalent, but having the format as parameters makes it
indeed quite confusing and I usually check again how it
works everytime because of that.

Thanks for the explanation.

Regards,
--
Alexandre Janniaux
Videolabs