[vlc-devel] [PATCH 3/3] transcode: video: fix insertion of fps filter

[Francois Cartegnie]

Le 27/01/2021 à 17:04, Rémi Denis-Courmont a écrit :
> Le keskiviikkona 27. tammikuuta 2021, 10.58.32 EET Francois Cartegnie a écrit
> :
>> Le 26/01/2021 à 22:03, Rémi Denis-Courmont a écrit :
>>>> That's one example why we should have kept full init() clean() cycles
>>>> everywhere, and even if the init is zero op.
>>>
>>> We cannot keep something we literally never had. And lets not even get
>>> started on lack of error handling and the probability to make it happen
>>> without introducing even more bugs.
>>
>> I remember did remove the union at some point
> 
> In other words, you made a ugly hack that partially papered over the issue,
> increased memory consumption, and effectively regressed work I'd done.

After check, my memory is wrong. The problematic change was not a 
dynamic alloc based on category, but,
the change from split members to a union, and parts of code reusing 
format across categories without cleanup in between.

The es_format_Change was rejected, and mandatory init/clean or 
setter/getters as well.

-- 
Francois Cartegnie
VideoLAN - VLC Developer