[vlc-devel] [PATCH 0/6] iOS OpenGL ES2 module

Alexandre Janniaux ajanni at videolabs.io
Fri Jan 29 09:40:16 UTC 2021


Hi,

Actually I forgot some removal parts regarding distcheck
it seems:

diff --git a/po/POTFILES.in b/po/POTFILES.in
index 0377c783bb..9f01428a47 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -1268,7 +1268,6 @@ modules/video_output/caopengllayer.m
 modules/video_output/decklink.cpp
 modules/video_output/fb.c
 modules/video_output/glx.c
-modules/video_output/ios.m
 modules/video_output/kva.c
 modules/video_output/macosx.m
 modules/video_output/opengl/display.c

I'll integrate this into the ios.m removal patch.

Regards,
--
Alexandre Janniaux
Videolabs

On Fri, Jan 29, 2021 at 09:24:29AM +0100, Thomas Guillem wrote:
> Patch set LGTM
>
> On Thu, Jan 28, 2021, at 17:57, Alexandre Janniaux wrote:
> > Hi,
> >
> > The following patch replace the iOS specific display by an iOS
> > specific OpenGL implementation. It sits on top of the previous
> > OpenGL patches that I've sent here, because of the API variant
> > detection:
> >
> > https://mailman.videolan.org/pipermail/vlc-devel/2021-January/141786.html
> >
> > The changes in the interop are potentially independant fixes.
> >
> > The assertion is mainly there because there should be no failures
> > in making it current at this location, and any failure is
> > actually a context management error (like, context already
> > bounded elsewhere).
> >
> > Regards,
> >
> > Alexandre Janniaux (6):
> >   video_output: Makefile.am: remove OpenGLES from uiview
> >   opengl: ensure opengl context is current
> >   ios: move caeagl implementation out of display
> >   ios: display: delete obsolete display module
> >   interop_cvpx: init last_cvtexs the first time
> >   interop_cvpx: hold previous texture on iOS too
> >
> >  modules/video_output/Makefile.am           |  17 +-
> >  modules/video_output/apple/VLCOpenGLES2VideoView.m        | 495 ++++++++++++++
> >  modules/video_output/ios.m                 | 747 ---------------------
> >  modules/video_output/opengl/display.c      |   3 +-
> >  modules/video_output/opengl/interop_cvpx.m |  23 +-
> >  5 files changed, 525 insertions(+), 763 deletions(-)
> >  create mode 100644 modules/video_output/apple/caeagl.m
> >  delete mode 100644 modules/video_output/ios.m
> >
> > --
> > 2.30.0
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list