[vlc-devel] [PATCH 01/11] os2: thread: implement missing threading functions

[Rémi Denis-Courmont]

Le keskiviikkona 27. tammikuuta 2021, 13.33.33 EET KO Myung-Hun a écrit :
> Hi/2.
> 
> Rémi Denis-Courmont wrote:
> > Le maanantaina 25. tammikuuta 2021, 15.18.07 EET KO Myung-Hun a écrit :
> >> Hi/2.
> >> 
> >> Rémi Denis-Courmont wrote:
> >>> Hi,
> >>> 
> >>> Where is the atomic-wait algorithm from? It's entirely clear to me if
> >>> it's
> >>> correct.
> >> 
> >> It was ported from posix/wait.c and win32/thread.c.
> >> 
> >> Any problem ?
> > 
> > Doesn't look to me like it works if there are more than one concurrent
> > waiter.
> Even if vlc_atomic_notify_one() is redirected to vlc_atomic_notify_all() ?

You can certainly use a correct implementation of notify_all as an 
implementation of notify_one, if you don't  care about performance. But I 
don't see how it helps if the notify_all() implementation looks incorrect in 
the first place.

-- 
Rémi Denis-Courmont
http://www.remlab.net/