[vlc-devel] [PATCH 1/2] freetype: fix subtitle text does not show correctly on OS/2

KO Myung-Hun komh78 at gmail.com
Wed Jul 28 04:57:16 UTC 2021


Hi/2.

Francois Cartegnie wrote:
> Le 05/03/2021 à 13:22, KO Myung-Hun a écrit :
> 
>>>
>>
>> Ok, fixed.
>>
> 
> +    psz_ucs2 = ( uint16_t * )psz_ucs4;
> +    i_len = i_ucs4_bytes / sizeof( *psz_ucs4 );
> +    /* Copy including NULL-terminator */
> +    for( int i = i_len; i >= 0; --i )
> +        psz_ucs4[ i ] = psz_ucs2[ i ];
> 
> 
> do we have any guarantee unichar_t is 4 bytes on OS/2 ?
> 

Yes, unichar_t is defined to uint32_t like any other platforms.

Anyway, I've simplified codes as well as using uint32_t instead of
unichar_t explicitly.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v6.1.10 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.os2.kr/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-freetype-fix-subtitle-text-does-not-show-correctly-o.patch
Type: application/x-patch
Size: 4378 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20210728/a52431ff/attachment.bin>


More information about the vlc-devel mailing list