[vlc-devel] [PATCH] gui: qt: don't condition plugin import based on QT_STATICPLUGIN
robux4 at ycbcr.xyz
Mon Mar 1 07:15:13 UTC 2021
On 2021-02-27 10:52, Steve Lhomme wrote:
> On 2021-02-26 18:12, Alexandre Janniaux wrote:
>> I meant, the documentation is quite confusing here, and the commit
>> adding the ifdef is more precise than yours, so giving more
>> explanation would avoid back and forth commits.
>> TBH, source code is not really a stable interface, especially
>> when it comes to Qt, so probably just an argument for «this
>> can't hurt currently». ;)
> When in doubt between the documentation and the source code, the source
> code always wins. But in this case even the documentation leans towards
> my explanation, although it could do with more clarity, especially given
> the confusing statements found inline (and even in our code).
> I can add some more explanation in the commit log, but the I'm not going
> to add documentation in the code for a define that is not there.
More information about the vlc-devel