[vlc-devel] [PATCH 6/7] egl_display: improve support detection

Romain Vimont rom1v at videolabs.io
Wed Mar 3 18:07:35 UTC 2021


On Wed, Mar 03, 2021 at 07:03:18PM +0100, Romain Vimont wrote:
> On Wed, Mar 03, 2021 at 07:46:47PM +0200, Rémi Denis-Courmont wrote:
> > Le keskiviikkona 3. maaliskuuta 2021, 19.36.39 EET Romain Vimont a écrit :
> > > +    display->display =
> > > +        eglGetPlatformDisplay(platform, EGL_DEFAULT_DISPLAY, attribs);
> > 
> > Won't this fail badly with EGL < 1.5 ?
> 
> In theory, yes. However, the CI is happy:
> https://code.videolan.org/rom1v/vlc/-/pipelines/74458

In fact, it could not fail, the call is in a ifdef
EGL_KHR_display_reference, which requires EGL 1.5:
https://www.khronos.org/registry/EGL/extensions/KHR/EGL_KHR_display_reference.txt

Regards


More information about the vlc-devel mailing list