[vlc-devel] [PATCH v2] egl_pbuffer: add missing call to eglTerminate()

Romain Vimont rom1v at videolabs.io
Mon Mar 8 15:51:24 UTC 2021


The function eglInitialize() was called on open, but eglTerminate() was
not called on close or error.
---
 modules/video_filter/egl_pbuffer.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/modules/video_filter/egl_pbuffer.c b/modules/video_filter/egl_pbuffer.c
index 69d68c27c9..e39d0e0a42 100644
--- a/modules/video_filter/egl_pbuffer.c
+++ b/modules/video_filter/egl_pbuffer.c
@@ -383,6 +383,7 @@ static void Close( vlc_gl_t *gl )
     vt->DeleteTextures(BUFFER_COUNT, sys->textures);
     vlc_gl_ReleaseCurrent(sys->gl);
 
+    eglTerminate(sys->display);
     vlc_egl_display_Delete(sys->vlc_display);
 }
 
@@ -478,7 +479,8 @@ static int Open(vlc_gl_t *gl, unsigned width, unsigned height)
     return VLC_SUCCESS;
 
 error2:
-    vlc_object_delete(sys->gl);
+    eglTerminate(sys->display);
+    vlc_egl_display_Delete(sys->vlc_display);
 error1:
     vlc_obj_free(&gl->obj, sys);
 
-- 
2.30.1



More information about the vlc-devel mailing list