[vlc-devel] [PATCH 4/6] smb2: use new happy eyeballs API

[Rémi Denis-Courmont]

Le mardi 9 mars 2021, 13:06:41 EET Thomas Guillem a écrit :
> On Wed, Mar 3, 2021, at 18:38, Rémi Denis-Courmont wrote:
> > Le tiistaina 2. maaliskuuta 2021, 16.52.23 EET Thomas Guillem a écrit :
> > > Connect to all resolved addresses in parallel, waiting 100ms between
> > > each new connection.
> > 
> > AFAIK, Happy Eyeballs is meant for the Internet, not private networks. But
> > then, CIFS/SMB is pretty only for private netwoks, not the Internet...
> 
> A lot of NAS support both IPv4 and IPv6 but have smb2 server listening on
> only one IP type. The happy eyeballs algorithm seems a very good way to
> solve this issue, as advised by Martin.

I fail to see how it "seems" so.

If the UNC locator has an IP literal, then Happy Eyeballs cannot be used in 
the first place. And if the UNC locator has a NetBIOS server name, then it will 
resolve to resolve the correct address family.

Happy Eyeballs is meant for the Internet, as in it's meant for use with the 
public DNS system.

-- 
Rémi Denis-Courmont