[vlc-devel] [PATCH 00/17] Fixing normal_time handling

Thomas Guillem thomas at gllm.fr
Wed Mar 10 13:33:55 UTC 2021


FYI, GET_TIME is stil used by the player timer to report the time when the demux doesn't have any programs/PCR/ES (so no valid data).

On Wed, Mar 10, 2021, at 13:55, Rémi Denis-Courmont wrote:
> Actually no. We should just ditch GET_TIME entirely, and report the offset from timestamps to normal play time when that offset changes (as opposed to when the PCR changes). The offset is essentially the PTS value corresponding to NPT zero.
> 
> Reporting values that change all the time does not make sense. Or rather it's impossible.
> 
> The issue is what to do with GET_POSITION. If there is a known length, then we can compute position as:
> NPT = PTS - PTS_offset
> Position = NPT / Length
> 
> But is there a demuxer that can compute a position but not a total length?
> 
> Le 10 mars 2021 13:51:53 GMT+02:00, "Rémi Denis-Courmont" <remi at remlab.net> a écrit :
>> Hi,
>> 
>> I can see the argument for converting GET_TIME and GET_POSITION to events, and then GET_TITLE, and GET_CHAPTER. But duration (GET_LENGTH) and NPT offset are mostly constant. NPT does not look like the most pressing issue in terms of conversion from polling to event.
> 
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20210310/d0aea3ae/attachment.html>


More information about the vlc-devel mailing list