[vlc-devel] [PATCH 18/25] qml: remove unused function calls and properties
Prince Gupta
guptaprince8832 at gmail.com
Thu Mar 11 09:16:26 UTC 2021
---
modules/gui/qt/player/qml/ControlBar.qml | 2 --
modules/gui/qt/player/qml/Player.qml | 10 +---------
modules/gui/qt/player/qml/TopBar.qml | 7 +------
3 files changed, 2 insertions(+), 17 deletions(-)
diff --git a/modules/gui/qt/player/qml/ControlBar.qml b/modules/gui/qt/player/qml/ControlBar.qml
index bbc650e63d..a867bca770 100644
--- a/modules/gui/qt/player/qml/ControlBar.qml
+++ b/modules/gui/qt/player/qml/ControlBar.qml
@@ -37,8 +37,6 @@ Widgets.NavigableFocusScope {
LeftRightSlider
}
- signal showTrackBar()
-
readonly property alias sliderY: row2.y
property int textPosition: ControlBar.TimeTextPosition.AboveSlider
property VLCColors colors: VLCStyle.nightColors
diff --git a/modules/gui/qt/player/qml/Player.qml b/modules/gui/qt/player/qml/Player.qml
index b98c55bfe2..bf9a414552 100644
--- a/modules/gui/qt/player/qml/Player.qml
+++ b/modules/gui/qt/player/qml/Player.qml
@@ -109,12 +109,9 @@ Widgets.NavigableFocusScope {
enabled: rootPlayer.hasEmbededVideo
anchors.fill: parent
- property point mousePosition: Qt.point(0,0)
-
- onMouseMoved:{
+ onMouseMoved: {
//short interval for mouse events
toolbarAutoHide.setVisible(1000)
- mousePosition = Qt.point(x, y)
}
}
@@ -260,7 +257,6 @@ Widgets.NavigableFocusScope {
z: 1
edge: Widgets.DrawerExt.Edges.Top
-
state: "visible"
component: FocusScope {
@@ -272,12 +268,10 @@ Widgets.NavigableFocusScope {
id: topbar
anchors.fill: parent
-
focus: true
visible: !resumeDialog.visible
title: mainPlaylistController.currentItem.title
colors: rootPlayer.colors
-
navigationParent: rootPlayer
navigationDownItem: playlistpopup.showPlaylist ? playlistpopup : (audioControls.visible ? audioControls : controlBarView)
@@ -474,7 +468,6 @@ Widgets.NavigableFocusScope {
id: playlistpopup
property bool showPlaylist: false
- property var previousFocus: undefined
anchors {
top: parent.top
@@ -504,7 +497,6 @@ Widgets.NavigableFocusScope {
function closePlaylist() {
playlistpopup.showPlaylist = false
- controlBarView.forceActiveFocus()
if (audioControls.visible)
audioControls.forceActiveFocus()
else
diff --git a/modules/gui/qt/player/qml/TopBar.qml b/modules/gui/qt/player/qml/TopBar.qml
index 5370e8f61f..73cf472e61 100644
--- a/modules/gui/qt/player/qml/TopBar.qml
+++ b/modules/gui/qt/player/qml/TopBar.qml
@@ -29,18 +29,13 @@ import "qrc:///menus/" as Menus
Widgets.NavigableFocusScope{
id: topFocusScope
- implicitHeight: topcontrolContent.implicitHeight
-
property alias title: titleText.text
property VLCColors colors: VLCStyle.nightColors
signal tooglePlaylistVisibility()
signal requestLockUnlockAutoHide(bool lock, var source)
- function forceFocusOnPlaylistButton() {
- playlistButton.forceActiveFocus()
- }
-
+ implicitHeight: topcontrolContent.implicitHeight
Keys.priority: Keys.AfterItem
Keys.onPressed: defaultKeyAction(event, 0)
--
2.25.1
More information about the vlc-devel
mailing list