[vlc-devel] [vlc-commits] clock: add vlc_clock_main_SetInputDrift

[Thomas Guillem]

On Fri, Mar 12, 2021, at 16:58, Rémi Denis-Courmont wrote:
> Le vendredi 12 mars 2021, 17:36:03 EET Thomas Guillem a écrit :
> > On Fri, Mar 12, 2021, at 16:31, Rémi Denis-Courmont wrote:
> > > Le vendredi 12 mars 2021, 17:04:06 EET Thomas Guillem a écrit :
> > > > Hello,
> > > > 
> > > > On Fri, Mar 12, 2021, at 15:19, Rémi Denis-Courmont wrote:
> > > > > Le vendredi 12 mars 2021, 15:44:32 EET Thomas Guillem a écrit :
> > > > > > vlc | branch: master | Thomas Guillem <thomas at gllm.fr> | Mon Mar  8
> > > > > > 15:50:47 2021 +0100| [dec93c823c33b91a4e968f19c0879d9efaeed7e5] |
> > > > > > committer: Thomas Guillem
> > > > > > 
> > > > > > clock: add vlc_clock_main_SetInputDrift
> > > > > 
> > > > > WTF? I'm pretty sure I rejected this patch.
> > > > 
> > > > I sent a new version more than 2 days ago.
> > > 
> > > Which was also rejected.
> > 
> > When was it rejected ? You just said you ignored it.
> > 
> > > I guess I'll be ignoring review comments from now on too.
> > 
> > Come on, it's jut a misunderstanding. I thought a link on code.videolan.org
> > was enough, I should have sent the 2 patches to the ML.
> > 
> > Can we handle this situation gently instead? I still don't know what is
> > wrong with my patch...
> 
> A patch that makes fundamental changes to the core clock, easily the most 
> sensitive piece of code in the entire project, is not documented, is not 
> according to agreed-upon plans and has not been favorably reviewed by anybody. 
> You don't see what is wrong with that?

I sent the V1 more than one week ago. I sent a V2 after your review. I hot fixed the V2 by adding more comments and pointed commits in code.videolan.org, I waited 2 more days.

I can see why it can be seen as wrong by some people (I should not have hotfixed commits), but I do think I respected (roughly) the review protocol.

Anyway, I push --forced the reset and send a new version. Let's wait for more reviews.

> 
> "Come on."
> 
> 
> And I don't mean me. I'd rather Denis review it than me in fact.
> 
> -- 
> Rémi Denis-Courmont
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel