[vlc-devel] [PATCH] contrib: nfs: Patch win32_compat.h to not override snprintf

Thomas Guillem thomas at gllm.fr
Mon Mar 15 09:05:54 UTC 2021


Sorry for the breakage and thanks for the fix!

On Mon, Mar 15, 2021, at 07:51, Steve Lhomme wrote:
> So LGTM
> 
> On 2021-03-15 7:45, Martin Storsjö wrote:
> > On Mon, 15 Mar 2021, Steve Lhomme wrote:
> > 
> >> Why not just comment it out the same way as 
> >> 6564abaa1f979c0b62044f695030a32b60620163 ? If it's an MSVC 
> >> compatibility we probably don't care too much. It would have the 
> >> benefit of not breaking the patch if/when we upgrade to libnfs 4.0.
> > 
> > Sure, I can do that as well, and that should work fine with modern MSVC 
> > anyway.
> > 
> > // Martin
> > 
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list