[vlc-devel] [PATCH v3 2/6] clock: add vlc_clock_main_SetInputDrift

[Francois Cartegnie]

Le 15/03/2021 à 12:06, Denis Charmet a écrit :

>> -    return system + (clock->delay - main_clock->delay) * rate;
>> +    return system + main_clock->input_drift +
> 
> You cannot do that. The whole point of the main clock is to be the 
> reference used to calculate the different drifts of other clocks. The 
> main clock cannot drift it's the monotonic clock if you start doing that 
> you are basically going back to the PCR master of the previous versions.
> 

That's how drift was handled before: Do an average and add it to clock 
computation.

You can't accelerate playback on master/audio clock.
You can't accelerate clock on the remote server.
We don't want to reset clock each time we reach some limit.

Now that was removed we have both clocks drifting away and eventually 
breaking up playback.


-- 
Francois Cartegnie
VideoLAN - VLC Developer