[vlc-devel] [PATCH v3 2/6] clock: add vlc_clock_main_SetInputDrift

[Rémi Denis-Courmont]

Le tiistaina 16. maaliskuuta 2021, 22.45.36 EET Alexandre Janniaux a écrit :
> > - Sometimes playback never "catches up".
> 
> What do you mean by «never catches up»?

The same symptoms as Thomas claims to be happening now.

> > - Especially as start/resume, doppler sound effect (resampling) due to
> > abnormally quick succession of SetPCR calls.

> The «doppler sound effect» on 3.0 and the artifacts were
> happening because of the way this clock was implemented, ie
> it's only about how you resample and filter the result.

No. It's about how the clock was measured. Resampling was working as intended 
when the master clock and the audio clock drift from one another.

> It doesn't mean that using the input PCR is incorrect.

Actually, it does mean exactly that.

-- 
Rémi Denis-Courmont
http://www.remlab.net/