[vlc-devel] [PATCH 0/2] Update error handling to be properly displayed (v2)

Benjamin Arnaud benjamin.arnaud at videolabs.io
Thu Mar 18 09:36:26 UTC 2021

This patch is a fix for the following: "error happening at startup might not be displayed" (https://code.videolan.org/chub/vlc/-/issues/28)

It makes sure that an error (or a collection of errors) that occured *before* the GUI are displayed once it's made visible. It also implements a dedicated "error" model for the Dialog QML view.

The error "popup" should be revamped soon since it's currently not optimal visually and in terms of behavior.

Update: Based on Romain and Pierre feedback, the DialogErrorModel is now a member of DialogModel.

Benjamin Arnaud (2):
  qt/dialogmodel: Update error handling before the GUI display
  qml/Dialogs: Update error handling with the global object

 .../gui/qt/dialogs/dialogs/dialogmodel.cpp    | 208 +++++++++++++-----
 .../gui/qt/dialogs/dialogs/dialogmodel.hpp    | 175 +++++++++++----
 .../gui/qt/dialogs/dialogs/qml/Dialogs.qml    | 165 ++++++++------
 modules/gui/qt/maininterface/mainui.cpp       |   5 +-
 4 files changed, 389 insertions(+), 164 deletions(-)


More information about the vlc-devel mailing list