[vlc-devel] [PATCH 11/14] contrib: patch libupnp to expose HTTP headers
asenat at posteo.net
Fri Mar 19 16:09:31 UTC 2021
Hi, thanks for the review!
On Fri, Mar 19, 2021 at 16:42, Rémi Denis-Courmont <remi at remlab.net>
> 1) It seems like a dangerous idea from forward compatibility
> standpoint. It
> creates an implicit dependency on the set of headers that the library
> or not, which might easily break on updates.
Agreed, I based this idea on the design of the libupnp's http callbacks
only give you access to the headers that the http server don't process
awkward for the reasons you just mentionned.
IMO a better option for libupnp would just be to let the library users
access the whole
set of http headers and that's it. I'll see if this is not too annoying
to implement on the
> 2) The version dependencies in contrib and configure *must* reflect
> the API
Since I just upstreamed the patch last week, there's no libupnp release
that feature yet. Maybe we can wait for a release and i'll just bump to
the new version
discarding the patch in contribs.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the vlc-devel