[vlc-devel] [PATCH 11/14] contrib: patch libupnp to expose HTTP headers

Alaric Senat asenat at posteo.net
Fri Mar 19 16:09:31 UTC 2021

Hi, thanks for the review!

On Fri, Mar 19, 2021 at 16:42, RĂ©mi Denis-Courmont <remi at remlab.net> 
> 1) It seems like a dangerous idea from forward compatibility 
> standpoint. It
> creates an implicit dependency on the set of headers that the library 
> manages
> or not, which might easily break on updates.

Agreed, I based this idea on the design of the libupnp's http callbacks 
where they
only give you access to the headers that the http server don't process 
which is
awkward for the reasons you just mentionned.
IMO a better option for libupnp would just be to let the library users 
access the whole
set of http headers and that's it. I'll see if this is not too annoying 
to implement on the
libupnp side.

> 2) The version dependencies in contrib and configure *must* reflect 
> the API
> requirements.
Since I just upstreamed the patch last week, there's no libupnp release 
that supports
that feature yet. Maybe we can wait for a release and i'll just bump to 
the new version
discarding the patch in contribs.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20210319/f9ae3ffb/attachment.html>

More information about the vlc-devel mailing list