[vlc-devel] [PATCH v3 2/6] clock: add vlc_clock_main_SetInputDrift

[Denis Charmet]

Hi,

On 2021-03-16 18:52, Alexandre Janniaux wrote:
> I'm not sure to understand, those issues arise with paced inputs
> but Thomas has been explicitely saying for three mails and in the
> patch itself that it copies the behaviour from 3.0 for non-paced
> stream.
> 
>> In 4.0, the master clock is no longer always the RTC, and the audio 
>> output
>> timing is handled differently in 4.0 as it was in 3.0.
>> 
>> So it's like comparing apples and oranges.
> 
> AFAIU Thomas is not trying to change the design of the clock. He
> is actually implementing what's in the design document from how it
> has been implemented previously, while wrapping it around the design
> of the main clock:


By modifying the main clock he is actually changing the design of the 
clock. We can already use a PCR master mode which should do exactly what 
he wants. If it doesn't then it's the PCR master mode that needs to be 
fixed first.

Regards,
-- 
Denis Charmet - TypX
Le mauvais esprit est un art de vivre