[vlc-devel] [PATCH 14/14] upnp_server: add the upnp server module

Alaric Senat dev.asenat at posteo.net
Mon Mar 22 18:09:47 UTC 2021


On Fri, Mar 19, 2021 at 14:44, Sean McGovern <gseanmcg at gmail.com> wrote:
> I just had a "devil's advocate" kind of thought go through my head
> when reading through this patchset.
> 
> Should the ML component possibly have security restrictions to prevent
> other modules in VLC from querying it when really they shouldn't?

Hi, sorry for the late answer my mail client didn't send it the first 
time..

There's no such protection for the moment. I actually thought the 
medialib instance
was only queryable by an interface module like the main playlist but 
its currently not
the case.
But in the case of the main playlist for example, this is only a matter 
of guiding the
modules implementers and tell them that they shouldn't access the main 
playlist
if they are not working on an interface module.
Truly denying modules access to certains parts of the core would 
require isolating
modules in separate processes and that's not where we are now.

On Sat, Mar 20, 2021 at 23:58, Jean-Baptiste Kempf <jb at videolan.org> 
wrote:
> Please mention
> Close #261 in the commit log.

Sure, I added `Implements #261` at the end of the commit message as It 
has
the same behavior and will close the issue once merged!

Regards


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20210322/047e8170/attachment.html>


More information about the vlc-devel mailing list