[vlc-devel] PATCH: librist based access and access_output modules

Mon Mar 29 16:54:22 UTC 2021

Hello Thomas,
I have fixed every item using your and Alexandre's
suggestions in the comments of the commits. Accordingly, I
have prepared and attached the final 4 new patches.
This time, I used this forked repo:
https://code.videolan.org/rist/vlc/-/tree/librist

And here it the result of the CI:
https://code.videolan.org/rist/vlc/-/pipelines/82818

Regards,
Sergio
On Mon, 2021-03-22 at 15:29 +0100, Thomas Guillem wrote:
> Hello Sergio,
> 
> I sent few comments on your merge request, otherwise it
> looks good to me.
> 
> Could you send all your patches to the mailing list
> (after fixing my comments) for the merge to happen?
> 
> Best,
> Thomas Guillem
> 
> On Fri, Mar 19, 2021, at 16:59, Sergio M. Ammirata, Ph.D.
> wrote:
> > Hello Thomas,
> > 
> > I have done as you suggested.
> > 
> > I forked the VLC repo and created a branch called
> > librist in my fork. In that branch, I removed the old
> > rist modules and replaced them with the new librist
> > based ones (separate commits) with backward compatible
> > config options. I also added the librist library to the
> > contrib section.
> > 
> > Then, I created a merge request and verified that
> > librist and the VLC rist modules both compiled properly
> > in all 18 architectures.
> > 
> > Here is a link to the branch where you can see the 6
> > commits: 
> > https://code.videolan.org/sammirata/vlc/-/tree/librist
> > 
> > Here is the merge request: 
> > https://code.videolan.org/sammirata/vlc/-/merge_requests/1
> > Here are the successful results of the compilation on
> > all the OSes: 
> > https://code.videolan.org/sammirata/vlc/-/pipelines/79549
> > 
> > Because librist only support mbedtls which it is not
> > part of the contribs and does not seem to be an easy
> > addition (I tried), for now, I am compiling it without
> > external encryption library support which means two
> > things:
> > 1) For any architecture except linux, AES will be
> > software only (no hardware acceleration).
> > 2) The library will not have support for SRP
> > authentication.
> > 
> > We plan to add support for gnutls at a later date and
> > then turn those extra features on.
> > 
> > If there is anything else needed for the merge to
> > happen, please let me know.
> > 
> > Regards,
> > 
> > Sergio
> > 
> > On Wed, 2021-02-03 at 10:12 +0100, Thomas Guillem
> > wrote:
> > > Hello,
> > > 
> > > it's hard to review a .patch file.
> > > 
> > > Please send your patch inline or send a link to a
> > > gitlab/github MR/branch.
> > > 
> > > I would really prefer if we remove the old one when
> > > adding this new one. If you are not sure libRIST is
> > > built on all platforms supported by VLC, just do a
> > > merge request to your own repo, with contrib librist,
> > > and the librist module in order to trigger the CI.
> > > That way, we will know which platforms need fixes.
> > > 
> > > On Wed, Feb 3, 2021, at 02:43, Sergio M. Ammirata,
> > > Ph.D. wrote:
> > > > Any feedback?
> > > > 
> > > > On Thu, 2021-01-14 at 22:22 -0500, Sergio M.
> > > > Ammirata, Ph.D. wrote:
> > > > > Here is a revised patch with compatible config
> > > > > settings (all items below fixed). I also reduced
> > > > > the number of settings to the minimum required.
> > > > > 
> > > > > Regards,
> > > > > 
> > > > > Sergio
> > > > > 
> > > > > On Sun, 2020-12-27 at 16:39 +0100, Jean-Baptiste
> > > > > Kempf wrote:
> > > > > > On Sun, 27 Dec 2020, at 14:15, Sergio M.
> > > > > > Ammirata, Ph.D. wrote:
> > > > > > > The config options do not match 100% either.
> > > > > > > Here is the analysis on the config options:
> > > > > > > 1) The config for the buffer size is called
> > > > > > > "latency" on native rist and "buffer" in the
> > > > > > > librist module.
> > > > > > 
> > > > > > Fix this.
> > > > > > 
> > > > > > > 2) There are a few config options present in
> > > > > > > native rist that do not exist on the librist
> > > > > > > module (packet-size, maximum-jitter, nack-
> > > > > > > type, disable-nacks, mcast-blind-nacks).
> > > > > > 
> > > > > > Fix this.
> > > > > > 
> > > > > > > 3) There are a number of new config options
> > > > > > > present in librist module that do not exist
> > > > > > > in native rist. These are expected as the new
> > > > > > > settings/options are related to encryption,
> > > > > > > selecting profile levels, multiplexing,
> > > > > > > multipath, congestion control and timing
> > > > > > > mode.
> > > > > > 
> > > > > > Remove the unneeded ones. We have too many
> > > > > > already.
> > > > > > 
> > > > > > Best,
> > > > > > 
> > > > > > --
> > > > > > Jean-Baptiste Kempf -  President
> > > > > > +33 672 704 734
> > > > > >  
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > _______________________________________________
> > > > > vlc-devel mailing list
> > > > > To unsubscribe or modify your subscription
> > > > > options:
> > > > > https://mailman.videolan.org/listinfo/vlc-devel
> > > > _______________________________________________
> > > > vlc-devel mailing list
> > > > To unsubscribe or modify your subscription options:
> > > > https://mailman.videolan.org/listinfo/vlc-devel
> > > 
> > > _______________________________________________
> > > vlc-devel mailing list
> > > To unsubscribe or modify your subscription options:
> > > https://mailman.videolan.org/listinfo/vlc-devel
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> 
> _______________________________________________vlc-devel
> mailing listTo unsubscribe or modify your subscription
> options:https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20210329/a50f5a3a/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-old-RIST-modules.patch
Type: text/x-patch
Size: 86692 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20210329/a50f5a3a/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Upgrade-meson-to-0.56.2-needed-to-build-librist.patch
Type: text/x-patch
Size: 1890 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20210329/a50f5a3a/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Add-librist-to-contrib.patch
Type: text/x-patch
Size: 1778 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20210329/a50f5a3a/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Add-libRIST-based-access-and-access_output-modules.patch
Type: text/x-patch
Size: 45939 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20210329/a50f5a3a/attachment-0007.bin>