[vlc-devel] PATCH: librist based access and access_output modules

[Thomas Guillem]

Hello,

I asked Sergio to remove the old module mainly for maintenance purpose (so that we won't have to debug 2 modules). I didn't think about the compatibility issue.

This will cause an issue mainly on Linux if the user or the distribution doesn't have librist.

I'm OK for both choices, but I still prefer removing the old one. What do you think?

On Tue, Mar 30, 2021, at 16:34, Sergio M. Ammirata, Ph.D. wrote:
> 
> Confirmed, you can safely ignore/skip the meson upgrade patch. 
> 
> Here is the pipeline test:
> https://code.videolan.org/sammirata/vlc/-/pipelines/83119
> 
> Regards,
> 
> Sergio
> 
> On Tue, 2021-03-30 at 09:03 -0400, Sergio M. Ammirata, Ph.D. wrote:
>> 
>> I can remove the requirement for the meson upgrade. It is only needed when the internal mbedtls subproject is used.
>> 
>> Sergio
>> 
>> On Tue, 2021-03-30 at 15:52 +0300, Rémi Denis-Courmont wrote:
>>> Le tiistaina 30. maaliskuuta 2021, 14.54.19 EEST Konstantin Pavlov a écrit :
>>> 
>>> On Tue, Mar 30, 2021 at 01:04:49PM +0300, Rémi Denis-Courmont wrote:
>>> 
>>> Le maanantaina 29. maaliskuuta 2021, 19.54.22 EEST Sergio M. Ammirata,
>>> Ph.D. a> 
>>> écrit :
>>> 
>>> Hello Thomas,
>>> I have fixed every item using your and Alexandre's
>>> suggestions in the comments of the commits. Accordingly, I
>>> have prepared and attached the final 4 new patches.
>>> This time, I used this forked repo:
>>> https://code.videolan.org/rist/vlc/-/tree/librist
>>> 
>>> I don't think we can add *new* requirements for *existing* features within
>>> a *stable* release branch.
>>> 
>>> -1 on upgrading Meson
>>> 
>>> We do it regularly for meson and other tools to fix various issues, so not
>>> sure why it's a problem now.
>>> 
>>> It's fine in the unstable branch(es). But people should be able to keep a 
>>> stable build environment for the stable branch, and some actually do that.
>>> 
>>> We've had no shortage of regressions and build issues due to changing the 
>>> stable branch build environments.
>>> 
>>> 
>>> 
>>> -1 on requiring a new library to support existing RIST use cases
>>> 
>>> Can we keep older modules with a lower priority instead of removing them?
>>> AFAICT it wouldnt be different to e.g. dav1d inclusion in around 3.0.5
>>> then.
>>> 
>>> I guess so.
>>> 
>>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20210330/594a0829/attachment.html>