[vlc-devel] MergeRequest process (bot) update

[Simon Latapie]

Hello Rémi,

On Sun, Jan 30, 2022, at 09:05, Rémi Denis-Courmont wrote:
> Le perjantaina 28. tammikuuta 2022, 1.21.42 EET Simon Latapie a écrit :
>> The acceptance process has been updated accordingly
>> (https://code.videolan.org/Garf/homer-bot/-/blob/master/doc/acceptance.md).
>
> Both the old and new versions have the same problem that CI failed state 
> conceals sets the review state to incompliant and conceals the actual *review* 
> state of the request.
>
> In an ideal system where CI result was 100% correct all the time, that might 
> be fine, but not in real life where CI fails due to externalities or 
> nondeterministic bugs.
>

Indeed. I tried to mitigate that behavior by inhibiting the bot actions when the CI is in an "unknown/wip" state, but this is not sufficient when the CI machines are under pressure (good example being the need to update contribs that de facto removes the prebuilt optimization).
I am not sure if there is a way to detect a real "failed" pipeline because of the commits from a "failed" pipeline because of an infrastructure disturbance.

Note that if this is okay for the reviewers, I could try to disable the "NotCompliant" status in case of a failed pipeline: that would probably result on less status wobbling - I still need to check the consequences on the other steps of the process, though.
I would probably still keep the pipeline success as mandatory for the Acceptable/Accepted states (they are mandatory for gitlab merge action no matter what).

Regards,

-- 
Simon Latapie
garf at videolan.org

> -- 
> 雷米‧德尼-库尔蒙
> http://www.remlab.net/
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel