[vlc-devel] [PATCH] build: set dependency to libvlc_rtp for librtp_plugin

[Dominique Leuenberger]

On Wed, 2023-07-12 at 15:46 +0200, Steve Lhomme wrote:
> Hello,
> 
> We don't handle patches anymore through this mailing list. You have
> to 
> submit your patch through our gitlab: 
> https://code.videolan.org/videolan/vlc/-/merge_requests

doh - I missed that... will adjust my workflows there.

> 
> But what you propose has already been tested and doesn't work in some
> cases:
> https://code.videolan.org/videolan/vlc/-/merge_requests/3806/diffs?diff_id=425819&start_sha=07077a57cb957bc81bd10b525d54e2ee6744f850

That's kinda strange - as not having it definitively does not work
(unless you possibly have a lingering .la file from earlier builds
around) - as seen on my build log excertp:

> > [ 1066s]   CC       access/rtp/librtp_plugin_la-input.lo
> > [ 1066s]   CC       access/rtp/librtp_plugin_la-sdp.lo
> > [ 1066s]   CC       access/rtp/librtp_plugin_la-datagram.lo
> > [ 1066s]   CC       access/rtp/librtp_plugin_la-rtp.lo
> > [ 1066s]   CC       access/rtp/libvlc_srtp_la-srtp.lo
> > [ 1067s]   CCLD     libvlc_srtp.la
> > [ 1067s]   CCLD     librtp_plugin.la
> > [ 1067s] libtool:   error: cannot find the library 'libvlc_rtp.la'
> > or
> > unhandled argument 'libvlc_rtp.la'
> > [ 1067s] make[4]: *** [Makefile:23838: librtp_plugin.la] Error 1
> > 

Let's look for a better, more versatile solution then.

Cheers,
  Dominique