vout_Probe breaks everything

[Gildas Bazin]

On Thursday 23 August 2001 7:33 pm, Michael Flohr wrote:
> Hi,
> just got vlc-0.2.83. 
> The xvideo extension does not work anymore.
> Lots of Gdk errors immediately after an attempt to open a window.
> Strangely, using the new option --xvadaptor #num with #num any number
> larger 0 helps, but then fullscreen does not anylonger work. I just
> get a small image within a large black area, as I know I get it under
> SDL.
> I searched around a bit in the code, and found that simply disabeling
> vout_Probe() in plugins/x11/vout_xvideo.c (I mean commenting out
> most of it except the trivial last few lines) restores everything
> to perfect working order for me.
> By the way, the small program textxv.c, mentioned in an earlier post
> works well for me.
> 

the XVideoGetPort() function in vout_xvideo.c is called twice. The first time 
in vout_Probe and the second time in vout_Create. From what you say, it seems 
it creates segfaults the second time it is run. Something must not be freed 
properly.

This function has been modified a few days ago to accomodate the problem with 
the 2 adaptors of the nvidia driver. We may have a nicer way now to deal with 
this but I don't have enough time for now to test it, maybe in a few days...

--
Gildas