vlc-cvs coredumps, debug mode patch

[Steven M. Schultz]

Greetings -

	I've been using vlc-cvs for some time on BSD/OS but today after
	the cvs update vlc coredumps in DVDRead.

	My first thought was to enable extra debugging and tracing in
	hopes that would provide additional information.  There were
	a couple problems compiling vlc with --enable-debug - a patch
	is below (very simple changes).

	It looks like DVDread is getting a NULL pointer passed thru for
	some strange reason but beyond that I don't know what is going
	on.

	I noticed that libdvdcss that is included with 'vlc' is older or
	not the same as the libdvdcss-1.0.0 available for download.  Is
	this on purpose or simply an oversight?

	Steven Schultz
	sms at 2bsd.com


-- Attached file included as plaintext by Listar --
-- File: p
-- Desc: DEBUG patch

--- plugins/x11/vout_xvideo.c.dist	Fri Dec 28 09:47:19 2001
+++ plugins/x11/vout_xvideo.c	Fri Dec 28 09:47:51 2001
@@ -208,7 +208,7 @@
         free( p_vout->p_sys );
         return 1;
     }
-    intf_DbgMsg( "Using xv port %d" , p_vout->p_sys->xv_port );
+    intf_DbgMsg( "Using xv port %d" , p_vout->p_sys->i_xvport );
 
     /* Create blank cursor (for mouse cursor autohiding) */
     p_vout->p_sys->b_mouse_pointer_visible = 1;
--- plugins/vcd/linux_cdrom_tools.c.dist	Fri Dec 28 08:34:47 2001
+++ plugins/vcd/linux_cdrom_tools.c	Fri Dec 28 09:38:39 2001
@@ -134,7 +134,6 @@
     p_msf->minute =   i_dummy / (CD_FRAMES * CD_SECS);
     p_msf->second = ( i_dummy % (CD_FRAMES * CD_SECS) ) / CD_FRAMES;
     p_msf->frame =  ( i_dummy % (CD_FRAMES * CD_SECS) ) % CD_FRAMES;
-#undef p_msf
 
 #ifdef DEBUG
     intf_DbgMsg( "vcd debug: playing frame %d:%d-%d",
@@ -158,5 +157,6 @@
     }
 
     return 1;
+#undef p_msf
 }
 

-- Attached file included as plaintext by Listar --
-- File: t
-- Desc: gdb debug info

Script started on Fri Dec 28 09:53:26 2001
awds59.1-> gdb /usr/local/bin/vlc vlc.core


GNU gdb 

Copyright 1998 Free Software Foundation, Inc.

GDB is free software, covered by the GNU General Public License, and you are

welcome to change it and/or distribute copies of it under certain conditions.

Type "show copying" to see the conditions.

There is absolutely no warranty for GDB.  Type "show warranty" for details.

This GDB was configured as "i386-unknown-bsdi4.3"...

Core was generated by `vlc'.

Program terminated with signal 11, Segmentation fault.

Reading symbols from /shlib/libm.so.0.0...done.

Reading symbols from /usr/local/lib/libdvd.so...done.

Reading symbols from /usr/X11R6/lib/libX11.so.6...done.

Reading symbols from /usr/X11R6/lib/libXext.so.6...done.

Reading symbols from /shlib/libdl.so...done.

Reading symbols from /shlib/libgcc.so.1...done.

Reading symbols from /shlib/libc.so.2...done.

Reading symbols from /shlib/ld-bsdi.so...done.

Reading symbols from /usr/local/src/vlc-cvs/plugins/ac3_spdif.so...done.

Reading symbols from /usr/local/src/vlc-cvs/plugins/spudec.so...done.

Reading symbols from /usr/local/src/vlc-cvs/plugins/chroma_yv12_rgb8.so...done.

Reading symbols from /usr/local/src/vlc-cvs/plugins/filter_bob.so...done.

Reading symbols from /usr/local/src/vlc-cvs/plugins/filter_invert.so...done.

Reading symbols from /usr/local/src/vlc-cvs/plugins/filter_wall.so...done.

Reading symbols from /usr/local/src/vlc-cvs/plugins/filter_transform.so...done.

Reading symbols from /usr/local/src/vlc-cvs/plugins/filter_distort.so...done.

Reading symbols from /usr/local/src/vlc-cvs/plugins/dsp.so...done.

Reading symbols from /usr/local/src/vlc-cvs/plugins/sdl.so...done.

Reading symbols from /usr/local/lib/libSDL-1.2.so.0...done.

Reading symbols from /usr/contrib/lib/libesd.so.0...done.

Reading symbols from /usr/contrib/lib/libaudiofile.so.0...done.

Reading symbols from /usr/local/src/vlc-cvs/plugins/gtk.so...done.

Reading symbols from /usr/contrib/lib/libgtk-1.2.so.0...done.

Reading symbols from /usr/contrib/lib/libgdk-1.2.so.0...done.

Reading symbols from /usr/contrib/lib/libgmodule-1.2.so.0...done.

Reading symbols from /usr/contrib/lib/libglib-1.2.so.0...done.

#0  0x80acfe7 in DVDRead (p_input=0x819e200, pp_data=0x822a670)

    at input_dvd.c:982

982             (*pp_data)->p_next = NULL;

(gdb) where

#0  0x80acfe7 in DVDRead (p_input=0x819e200, pp_data=0x822a670)

    at input_dvd.c:982

#1  0x804f455 in RunThread (p_input=0x819e200) at src/input/input.c:348

#2  0x4829fb65 in _thread_kern_start () from /shlib/libc.so.2

(gdb) print pp_data

$1 = (data_packet_t **) 0x822a670

(gdb) print *pp_data

$2 = (data_packet_t *) 0x0

(gdb) awds59.2-> exit


exit


Script done on Fri Dec 28 09:54:07 2001