vlc -> BSD/OS 4.3beta1

[Christophe Massiot]

On Mon, Jul 30, 2001, Steven M. Schultz wrote:

> 	That's all I had to do.  Then I sat back and watched movies the
> 	rest of the evening :)

That's really a great work. I will integrate this to the CVS soon. A few
questions though :

> --- ./extras/libdvdcss/ioctl.c.dist	Tue Jul 24 17:23:40 2001
> +++ ./extras/libdvdcss/ioctl.c	Sun Jul 29 12:46:11 2001
> @@ -60,6 +60,11 @@
>  #   include "DVDioctl/DVDioctl.h"
>  #endif
>  
> +#ifdef	__bsdi__
> +#include <dvd.h>
> +#define DVD_STRUCT_IN_LINUX_CDROM_H 1
> +#endif
> +
>  #include "ioctl.h"
>  
>  /*****************************************************************************

Why do you need to define this by hand ? Isn't it correctly detected by
configure ? A more correct fix would be to patch configure so that the
test works.

> --- ./Makefile.dep.dist	Fri Jul 27 19:30:25 2001
> +++ ./Makefile.dep	Sun Jul 29 12:31:02 2001
> @@ -46,7 +46,7 @@
>  -include $(MAKECMDGOALS)
>  
>  $(C_DEP): .dep/%.d: %.c
> -	@test -d .dep/$(dir $*) || mkdir -p .dep/$(dir $*)
> +	@test -d .dep/$(dir $*) || mkdir -p `dirname .dep/$*`

Wouldn't it be possible to use $(dir .dep/$*) instead ?

> --- ./Makefile.opts.in.dist	Fri Jul 27 19:30:25 2001
> +++ ./Makefile.opts.in	Sun Jul 29 20:47:45 2001
> @@ -173,6 +173,10 @@
>  
>  LIB += -L/usr/local/lib @LIB@
>  
> +ifeq ($(SYS),bsdi)
> +LIB += -ldvd
> +endif

Is it necessary to link the main application with libdvd ? Or just the
dvd plug-in ?

-- 
Christophe Massiot.