Patch: SYS_DARWIN1_3 not set on Mac OS X > 10.0.0
Colin Simmonds
colin_simmonds at Mac.lover.org
Sat Jun 23 20:45:51 CEST 2001
Under recent updated versions of Mac OS X (Darwin), the SYS_DARWIN1_3
define isn't being set because the operating system version reported by
uname changes with each kernel release, and this propagates up into the
SYS variable used by the build system.
Under Mac OS X 10.0.3, the SYS variable is reported in Makefile.opts as
darwin1.3.3, which leads to the compile-time define of SYS_DARWIN1_3_3.
After upgrading to Mac OS X 10.0.4, the SYS variable becomes darwin1.3.7
leading to a define of SYS_DARWIN1_3_7 (since Apple for some reason
incremented the minor version number reported by uname -r by 4 for this
minor update). Extrapolating back, I imagine similar problems exist
under 10.0.1 and 10.0.2 and the standalone (non Mac OS X) Darwin 1.3.1
release as well.
Since the conditional code in vlc for Darwin is controlled by the define
SYS_DARWIN1_3, this means that none of the Darwin-specific code is hit
for compiles on any recent release of Mac OS X.
Below is a patch which fixes this problem:
--- vlc-snapshot-20010621-00/configure.in Wed Jun 20 18:02:11 2001
+++ vlc-darwin-fixed/configure.in Sat Jun 23 14:07:09 2001
@@ -349,6 +349,13 @@
SYS=${host_os}
+dnl Ignore minor version number for Darwin / Mac OS X
+case $SYS in
+ darwin1.3*)
+ SYS=darwin1.3
+ ;;
+esac
+
dnl special case for BeOS
if test x$host_os = xbeos; then
BUILTINS="${BUILTINS} beos"
This is only a temporary fix, as it will break again whenever Apple
increments the version number to 1.4. Longer term, the SYS_DARWIN1_3
flag should be changed to SYS_DARWIN and the SYS variable set to plain
darwin without any version numbers at all.
Colin
More information about the vlc
mailing list