[vlc] Re: null pointer dereference in ty plugin Was: vlc streaming problems

[Florian Lohoff]

On Mon, Aug 15, 2005 at 05:30:17PM +0300, Rémi Denis-Courmont wrote:
> No, that's correct. If psz_ext is NULL, !psz_ext will be true, so 
> strcasecmp will NOT be called. The bug must be somewhere else.
> 
> Using valgrind or gdb might help.

Whatever - this patch fixed the problem for me - I'll retry to gather a
gdb backtrace ..

diff -Nur vlc-0.8.2/modules/demux/ty.c ../vlc-0.8.2/modules/demux/ty.c
--- vlc-0.8.2/modules/demux/ty.c        2005-06-25 15:43:06.000000000 +0200
+++ ../vlc-0.8.2/modules/demux/ty.c     2005-07-27 16:52:46.000000000 +0200
@@ -166,10 +166,12 @@
         /* doesn't look like a TY file... */
         char *psz_ext = strrchr(p_demux->psz_path, '.');

+#if 0
         if( !p_demux->b_force &&
             (!psz_ext || strcasecmp(psz_ext, ".ty")) ) return VLC_EGENERIC;
         msg_Warn( p_demux, "this does not look like a TY file, "
                   "continuing anyway..." );
+#endif
     }

     /* at this point, we assume we have a valid TY stream */



Flo
-- 
Florian Lohoff                  flo at rfc822.org             +49-171-2280134
                        Heisenberg may have been here.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://mailman.videolan.org/pipermail/vlc/attachments/20050816/ffcd5d77/attachment.sig>