[vlc] Re: mozilla plugin configuration file.

[Dermot McGahon]

>> It hasn't worked in a long time. It hasn't been important enough for
>> me to chase it down to completion. One thing I have done is to add "no"
>> cases for loop and fullscreen (see below).
>>
>
> Well, it seems to be broken indeed

Yes. I even knew why at point, but the exact reason escapes me
just now.


> The reason the vout plugin to use is not read from the config file is  
> that only xvideo and x11 can be embedded in the navigator. Other video  
> output cannot.

Fine, but check on the currently set vout with an override makes
more sense. Same for aout.

The way it is now, if somebody has xv capabilities but a broken
driver - the plugin won't work for them and they have to recompile.

Maybe not such a big deal.

The 100% CPU is the bigger problem, along with loop not working.

I tested loop and fullscreen - neither worked. I don't think it
is successfully setting any variables.

Here are is a patch to vlcshell.cpp that adds in ALSA, changes
the loading message and provide "loop|fullscreen=no" code (for
when we get that working).


Dermot.
--




Index: vlcshell.cpp
===================================================================
--- vlcshell.cpp        (revision 11091)
+++ vlcshell.cpp        (working copy)
@@ -77,7 +77,7 @@
  #include "vlcplugin.h"

  #if USE_LIBVLC
-#   define WINDOW_TEXT "(no picture)"
+#   define WINDOW_TEXT "(Please wait ...)"
  #else
  #   define WINDOW_TEXT "(no libvlc)"
  #endif
@@ -90,7 +90,7 @@
  ******************************************************************************/
  #ifdef XP_UNIX
  #   define VOUT_PLUGINS "xvideo,x11,dummy"
-#   define AOUT_PLUGINS "oss,dummy"
+#   define AOUT_PLUGINS "alsa,oss,dummy"

  static void Redraw( Widget w, XtPointer closure, XEvent *event );
  static void Resize( Widget w, XtPointer closure, XEvent *event );
@@ -282,6 +282,7 @@
          return NPERR_GENERIC_ERROR;
      }

+
      {
  #ifdef XP_MACOSX
          char *home_user;
@@ -353,8 +354,8 @@
      VLC_VariableSet( p_plugin->i_vlc, "conf::intf", value );
      value.psz_string = VOUT_PLUGINS;
      VLC_VariableSet( p_plugin->i_vlc, "conf::vout", value );
-    value.psz_string = AOUT_PLUGINS;
-    VLC_VariableSet( p_plugin->i_vlc, "conf::aout", value );
+    //value.psz_string = AOUT_PLUGINS;
+    //VLC_VariableSet( p_plugin->i_vlc, "conf::aout", value );

  #else /* USE_LIBVLC */
      p_plugin->i_vlc = 1;
@@ -402,6 +403,11 @@
                  value.b_bool = VLC_TRUE;
                  VLC_VariableSet( p_plugin->i_vlc, "conf::loop", value );
              }
+            else if (!strcmp (argn[i], "no" ) )
+            {
+                value.b_bool = VLC_FALSE;
+                VLC_VariableSet( p_plugin->i_vlc, "conf::loop", value );
+            }
          }
          else if( !strcmp( argn[i], "fullscreen" ) )
          {
@@ -410,6 +416,11 @@
                  value.b_bool = VLC_TRUE;
                  VLC_VariableSet( p_plugin->i_vlc, "conf::fullscreen",  
value );
              }
+            else if (!strcmp (argn[i], "no" ) )
+            {
+                value.b_bool = VLC_FALSE;
+                VLC_VariableSet( p_plugin->i_vlc, "conf::fullscreen",  
value );
+            }
          }
          else if( !strcmp( argn[i], "mute" ) )
          {


-- 
This is the vlc mailing-list, see http://www.videolan.org/vlc/
To unsubscribe, please read http://www.videolan.org/support/lists.html